Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/prompt-studio-UI {Adding new suggestions} #73

Merged
merged 4 commits into from
Mar 9, 2024

Conversation

athul-rs
Copy link
Contributor

@athul-rs athul-rs commented Mar 7, 2024

What

Prompt-Studio UI changes:

Added additional improvements on prompt part :

Why

...

How

...

Relevant Docs

Related Issues or PRs

Dependencies Versions / Env Variables

Notes on Testing

...

Screenshots

...

Checklist

I have read and understood the Contribution Guidelines.

@athul-rs athul-rs changed the title Fix/prompt-studio-UI Fix/prompt-studio-UI {Adding new suggestions} Mar 8, 2024
@athul-rs athul-rs marked this pull request as draft March 8, 2024 04:42
Copy link
Contributor

@tahierhussain tahierhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athul-rs Can you please add the invalid JSON error in the helper text, instead of displaying it in the popup? Also, can you please address @shuveb's request in the comments?

@athul-rs
Copy link
Contributor Author

athul-rs commented Mar 8, 2024

@athul-rs Can you please add the invalid JSON error in the helper text, instead of displaying it in the popup? Also, can you please address @shuveb's request in the comments?

Already Added.

@athul-rs athul-rs marked this pull request as ready for review March 8, 2024 11:26
Copy link
Contributor

@tahierhussain tahierhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@athul-rs athul-rs self-assigned this Mar 8, 2024
Copy link
Contributor

@hari-kuriakose hari-kuriakose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athul-rs LGTM overall.

@nehabagdia nehabagdia merged commit 961e5a3 into main Mar 9, 2024
1 check passed
@nehabagdia nehabagdia deleted the fix/prompt-studio-bugFix-Mar07 branch March 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants