-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Implement Drag-and-Drop Reordering for Prompts, Refactor Prompt Cards, and Update Export Modal Messaging #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahierhussain
requested review from
Deepak-Kesavan,
athul-rs,
jagadeeswaran-zipstack,
johnyrahul and
vishnuszipstack
October 22, 2024 18:35
vishnuszipstack
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Deepak-Kesavan
approved these changes
Oct 26, 2024
jagadeeswaran-zipstack
requested changes
Nov 4, 2024
Quality Gate passedIssues Measures |
|
jagadeeswaran-zipstack
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
1. Added Drag-and-Drop Reordering for Prompts:
PromptsReorder
component usingreact-dnd
to enable drag-and-drop functionality for reordering prompts.2. Refactored Prompt Cards:
PromptsReorder
component.3. Updated Export Modal Messaging:
Why
1. Enhanced User Experience:
2. Improved Code Maintainability:
3. Clarity in Export Functionality:
How
1. Implementing PromptsReorder Component:
react-dnd
library to create thePromptsReorder
component, which manages the drag-and-drop reordering of prompts.2. Refactoring Prompt Cards:
3. Updating Export Modal Message:
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Yes. This PR includes the creation of new components along with substantial changes to existing ones. So, there is a possibility that it may break existing features.
Database Migrations
NA
Env Config
NA
Relevant Docs
NA
Related Issues or PRs
NA
Dependencies Versions
NA
Notes on Testing
NA
Screenshots
Prompt Cards Before Reordering:
Prompts Reorder Modal (drag-and-drop cards to reorder):
Prompt Card After Reordering:
Checklist
I have read and understood the Contribution Guidelines.