-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updated run-platform to create schema for new users #820
Conversation
…ill have to run migrate-to-v2.sh script
@chandrasekharan-zipstack Let's also move |
@hari-kuriakose I've addressed it in this PR - can we let these be separate changes? Will resolve any conflicts accordingly |
…schema creation commands, minor run-platform.sh changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandrasekharan-zipstack LGTM overall
Can take care of the Django management commands security hotspots separately. |
What
run-platform.sh
to create DB schemamigrate-to-v2.sh
to allow talking to DB / redis in containersENTRYPOINT
toCMD
in backend's Dockerfile, to allow invoking the necessary schema creation commandutils
appWhy
public
schema would be present by defaultHow
backend/migrating/v2/migrate-to-v2.sh
to perform the schema creation and subsequent migrationCan this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Related Issues or PRs
Notes on Testing
/etc/hosts
entries to mimic the average OSS user to reproduce the same issues and worked on unblocking myselfScreenshots Old
To be used by new users, ran with trace option
Migration script (to be used by existing users)
Screenshots after addressing comments
Checklist
I have read and understood the Contribution Guidelines.