Implement structures #448
Merged
Implement structures #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…absy and typed_absy
…nt check to function check
Break current preliminary impl. as they have spec character.
stefandeml
previously approved these changes
Oct 6, 2019
| @@ -1035,6 +1232,9 @@ impl<'ast, T: Field> Flattener<'ast, T> { | |||
| assert!(exprs_flattened.expressions.len() == 1); // outside of MultipleDefinition, FunctionCalls must return a single value | |||
| exprs_flattened.expressions[0].clone() | |||
| } | |||
| FieldElementExpression::Member(box s, id) => { | |||
There was a problem hiding this comment.
no change but on line 1147 there is the following TODO:
// we require from the base to be linear
// TODO change that
this origins from this commit:
0b83db9
something we want to fix?
| mod variable; | ||
|
|
||
| pub use crate::typed_absy::parameter::Parameter; | ||
| pub use crate::typed_absy::variable::Variable; | ||
| use crate::types::{FunctionKey, Signature, Type}; | ||
|
|
||
| use crate::typed_absy::types::{FunctionKey, MemberId, Signature, Type}; |
There was a problem hiding this comment.
Line 77: Delete or add comment
| @@ -0,0 +1,120 @@ | |||
| //! Add runtime boolean checks on user inputs | |||
There was a problem hiding this comment.
That means we now check for all Boolean inputs strictly.
Eg in that example code:
struct A {
bool b
}
def main(A a) -> (field):
field dummy = 12
return dummywe will add boolean checks for the input a.
Co-Authored-By: Stefan <stefandeml@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement structures in ZoKrates:
Changes
from PATH import SYMBOL as ALIAS, we have backward compatibility by aliasingimport PATHtofrom PATH import main as PATH.FILENAME