-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrated bcrypt key derivation to argon2 and aead symmetric encryption #451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it seems like there are occasions where one could be trying to decrypt with a key generated the old way (with bcrypt), but with the 'new' (chachapoly) decryption algorithm, or vice versa (new key derivation algorithm but old symmetric decryption algorithm, which is in fact more of a problem since the salsa symmetric encryption algorithm is not an AEAD). I think the logic of DecryptPrivKey should be improved so that it is impossible that one attempts to decrypt using salsa decryption with a argon2id generated key.
…x/cosmos-sdk into feat/bcrypt-key-derivation-to-aead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, maybe someone with a better understanding of Go can also review this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
only thing what Eze commented!
Description
Closes: #3129
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change🔗 zboto Link