kIOMasterPortDefault is deprecated in MacOSX12.sdk

[SgtPooki]

During the install of lotus, the following error is received:

# github.com/zondax/hid
In file included from /Users/lindsayjowalker/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/zondax/hid@v0.9.0/hid_enabled.go:38:
./hidapi/mac/hid.c:693:34: error: use of undeclared identifier 'kIOMasterPortDefault'; did you mean 'kIOMainPortDefault'?
        entry = IORegistryEntryFromPath(kIOMasterPortDefault, path);
                                        ^~~~~~~~~~~~~~~~~~~~
                                        kIOMainPortDefault
/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:123:19: note: 'kIOMainPortDefault' declared here
const mach_port_t kIOMainPortDefault
                  ^
1 error generated.
make: *** [lotus-miner] Error 2
make: *** Waiting for unfinished jobs....
make: *** [lotus] Error 2
make: *** [lotus-worker] Error 2

[dwedul-figure]

I noticed that v0.9.0 differs from master in only one place, hidapi/mac/hid.c line 693:

• master has entry = IORegistryEntryFromPath(kIOMainPortDefault, path)
• v0.9.0 has entry = IORegistryEntryFromPath(kIOMasterPortDefault, path);

The kIOMainPortDefault variable does not yet exist in MacOS 11.0+ (BIg Sur). It was added in MacOS 12.0+ (Monterey).

On my Big Sur Mac, in another repo that pulls in this library as a dependency of a library in its go.mod, trying to build gives this error:

# github.com/zondax/hid
In file included from ../../go/pkg/mod/github.com/zondax/hid@v0.9.1-0.20220302062450-5552068d2266/hid_enabled.go:38:
./hidapi/mac/hid.c:693:34: error: use of undeclared identifier 'kIOMainPortDefault'
        entry = IORegistryEntryFromPath(kIOMainPortDefault, path);
                                        ^
1 error generated.
make: *** [build] Error 2

[web3jenks]

Any update on this issue?

[santanaluiz]

Yes, this was fix already on this PR
#5

Just missing to create a release/tag

[santanaluiz]

@jleni can you help us out here?

[ianconsolata]

@jleni can you cut a 0.9.1 release with this change? We'd like to update our dependencies to fix this issue, but can't without a new release.

[santanaluiz]

@ianconsolata you could point your dependency to the the branch or commit hash.
That would workaround. I faced some other issues on my dependency tree and gave up, but this step of the release you could skip :)

[ianconsolata]

Yup! That’s what I did in the PR linked above for now.