Fix ui issues #29
Merged
Fix ui issues #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Release
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
chcmedeiros
force-pushed
the
fix/ui
branch
2 times, most recently
from
65adcf5 to
472d9b5
Compare
chcmedeiros
force-pushed
the
fix/ui
branch
2 times, most recently
from
c8446ad to
d0f6200
Compare
emmanuelm41
approved these changes
Oct 14, 2024
app/src/parser.c
Outdated
| return parser_ok; | ||
| default: | ||
| break; | ||
| } | ||
|
|
||
| return parser_display_idx_out_of_range; | ||
| return parser_ok; |
There was a problem hiding this comment.
Should we return ok if we get here? Shouldn't it be an error?
There was a problem hiding this comment.
Yes it should! I will fix it!
emmanuelm41
reviewed
Oct 14, 2024
app/rust/src/lib.rs
Outdated
| .hash(&key_input) | ||
| .as_bytes() | ||
| .try_into() | ||
| .expect("has has incorrect length") |
There was a problem hiding this comment.
Typo here. Besides, this will panic. Shouldn't we handle the error differently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.