-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sliver of Active/Inactive Color Stuck In Titlebar With Borders #41
Comments
Ok, something had been stuck here. I switched around different themes and suddenly color changed to what i was supposed to be,
…--
jan
//jan.limpens.com
---- Ein Di, 16 Mär 2021 11:29:14 -0300 Chris Holland ***@***.***> schrieb ----
Pretty sure it uses the Color Theme's colors doesn't it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This, on the other hand, does not appear here. |
Do you have a border thickness set? I'm changed "No Borders" to "Thin" which is a 1px border. Change the color theme afterward, the select an inactive window you already had open. |
I did not find an option to set border thickness.
--
jan
//jan.limpens.com
…---- Ein Di, 16 Mär 2021 11:37:17 -0300 Chris Holland ***@***.***> schrieb ----
This, on the other hand, does not appear here.
Do you have a border thickness set? I'm changed "No Borders" to "Thin" which is a 1px border. Change the color theme afterward, the select an inactive window you already had open.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Ok, found it, but I did not see any artefacts after doing what you described.
…--
jan
//jan.limpens.com
---- Ein Di, 16 Mär 2021 11:46:26 -0300 Chris Holland ***@***.***> schrieb ----
It's not in the config popup. It's a setting at the bottom of the theme selector grid.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Hmm, I test again when I get back to X11 from Wayland. I doubt that's the issue though. I'm renaming this issue though since all the screenshots are here already. |
I'm also experiencing this issue, I use normal borders and X11 session. |
We were getting a slim sliver in the right side of the titlebar that was not repainting when the switching between inactive/active bg color due to older repaintTitlebar() code not taking it into account the titlebar is wider than the client window width when there's borders. We could probably replace all titleBarRect() calls with calls to Decoration::titleBar() now that I know about it.
Currently, I cannot define a difference between active and inactive windows, which leads to confusing overlapping where it is difficult to say, where one application window ends and another starts.
Material decoration should simply take the colours defined in system configuration and everybody would be happier.
The text was updated successfully, but these errors were encountered: