Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliver of Active/Inactive Color Stuck In Titlebar With Borders #41

Open
janlimpens opened this issue Mar 16, 2021 · 10 comments
Open

Sliver of Active/Inactive Color Stuck In Titlebar With Borders #41

janlimpens opened this issue Mar 16, 2021 · 10 comments

Comments

@janlimpens
Copy link

janlimpens commented Mar 16, 2021

Screenshot von 2021-03-16 11 23 45

Currently, I cannot define a difference between active and inactive windows, which leads to confusing overlapping where it is difficult to say, where one application window ends and another starts.

Material decoration should simply take the colours defined in system configuration and everybody would be happier.

@Zren
Copy link
Owner

Zren commented Mar 16, 2021

Pretty sure it uses the Color Theme's colors doesn't it?

2021-03-16___10-26-07

@Zren
Copy link
Owner

Zren commented Mar 16, 2021

Hmmm, you did make me notice a bug in the border code. Apparently there's a tiny sliver doesn't get repainted. It sticks with whatever color it had when the color theme was selected. So System Settings has the active color, and other windows have a sliver colored inactive.

2021-03-16___10-29-56

@janlimpens
Copy link
Author

janlimpens commented Mar 16, 2021 via email

@janlimpens
Copy link
Author

Hmmm, you did make me notice a bug in the border code. Apparently there's a tiny sliver doesn't get repainted. It sticks with whatever color it had when the color theme was selected. So System Settings has the active color, and other windows have a sliver colored inactive.

This, on the other hand, does not appear here.

@Zren
Copy link
Owner

Zren commented Mar 16, 2021

This, on the other hand, does not appear here.

Do you have a border thickness set? I'm changed "No Borders" to "Thin" which is a 1px border. Change the color theme afterward, the select an inactive window you already had open.

@janlimpens
Copy link
Author

janlimpens commented Mar 16, 2021 via email

@Zren
Copy link
Owner

Zren commented Mar 16, 2021

It's not in the config popup. It's a setting at the bottom of the theme selector grid.

2021-03-16___10-45-11

@janlimpens
Copy link
Author

janlimpens commented Mar 16, 2021 via email

@Zren
Copy link
Owner

Zren commented Mar 16, 2021

Hmm, I test again when I get back to X11 from Wayland. I doubt that's the issue though. I'm renaming this issue though since all the screenshots are here already.

@Zren Zren reopened this Mar 16, 2021
@Zren Zren changed the title Title/Menu Bar should respect system colors Sliver of Active/Inactive Color Stuck In Titlebar With Borders Mar 16, 2021
@giomatfois62
Copy link

I'm also experiencing this issue, I use normal borders and X11 session.
far right corner of the titlebar is stuck with the active color when the window looses focus.
Did not spot any obvious suspect in your painting code yet.

Zren added a commit that referenced this issue Apr 28, 2021
We were getting a slim sliver in the right side of the titlebar that
was not repainting when the switching between inactive/active bg color
due to older repaintTitlebar() code not taking it into account the
titlebar is wider than the client window width when there's borders.

We could probably replace all titleBarRect() calls with calls to
Decoration::titleBar() now that I know about it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants