Make provisioner ip configurable (jupyter-server#97)

* make provisioner ip configurable * bump version
Zsailer · Aug 25, 2021 · 328a33b · 328a33b
1 parent b0c9edc
commit 328a33b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/data_studio_jupyter_extensions/_version.py b/data_studio_jupyter_extensions/_version.py
@@ -1 +1 @@
-__version__ = "0.5.0"  # pragma: no cover
+__version__ = "0.6.0"  # pragma: no cover
diff --git a/data_studio_jupyter_extensions/provisioner.py b/data_studio_jupyter_extensions/provisioner.py
@@ -30,7 +30,7 @@
 class NotebookServiceProvisioner(provisioning.KernelProvisionerBase):
     """Kernel Provisioner that talks directly to the Notebook Service."""
 
-    ip = Unicode(allow_none=True)
+    ip = Unicode(allow_none=True).tag(config=True)
     iopub_port = IntFromEnv(name=constants.IOPUBPORT, allow_none=True)
     hb_port = IntFromEnv(name=constants.HBPORT, allow_none=True)
     control_port = IntFromEnv(name=constants.CONTROLPORT, allow_none=True)
@@ -367,7 +367,7 @@ async def _launch_kernel_local_to_local(self) -> KernelConnectionInfo:
 
         # Get the Host information from the kernel details endpoint.
         kernel_info = await self.nbservice_client.get_kernel_details(self.process_id)
-        self.ip = kernel_info["host"]
+        self.ip = self.ip or kernel_info["host"]
         return self.connection_info
 
     async def _launch_kernel_local_to_cluster(
@@ -385,7 +385,7 @@ async def _launch_kernel_local_to_cluster(
         self.control_port = port_map["control"]
         self.shell_port = port_map["shell"]
         self.stdin_port = port_map["stdin"]
-        self.ip = host
+        self.ip = self.ip or host
         return self.connection_info
 
     async def _launch_kernel_cluster_to_cluster(
@@ -397,7 +397,7 @@ async def _launch_kernel_cluster_to_cluster(
         # The connection info should be predetermined by the kernel itself.
         # Get the Host information from the kernel details endpoint.
         kernel_info = await self.nbservice_client.get_kernel_details(self.process_id)
-        self.ip = kernel_info["host"]
+        self.ip = self.ip or kernel_info["host"]
         return self.connection_info
 
     async def launch_kernel(

diff --git a/pyproject.toml b/pyproject.toml
@@ -23,7 +23,7 @@ testpaths = [
 ]
 
 [tool.tbump.version]
-current = "0.5.0"
+current = "0.6.0"
 regex = '''
   (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)
   ((?P<channel>a|b|rc|.dev)(?P<release>\d+))?

diff --git a/version b/version
@@ -1 +1 @@
-0.5.0
+0.6.0