Fix bug in scroll FX (#1591)

* Scroll fix
Zulko · May 31, 2021 · ec44869 · ec44869
1 parent 84582d9
commit ec44869
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -60,6 +60,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed rotation metadata of input not being taken into account rendering VideoClips [\#577](https://github.com/Zulko/moviepy/pull/577)
 - Fixed mono clips crashing when `audio_fadein` FX applied [\#1574](https://github.com/Zulko/moviepy/pull/1574)
 - Fixed mono clips crashing when `audio_fadeout` FX applied [\#1578](https://github.com/Zulko/moviepy/pull/1578)
+- Fixed scroll FX not being scrolling [\#1591](https://github.com/Zulko/moviepy/pull/1591)
 
 
 ## [v2.0.0.dev2](https://github.com/zulko/moviepy/tree/v2.0.0.dev2) (2020-10-05)

diff --git a/moviepy/video/fx/scroll.py b/moviepy/video/fx/scroll.py
@@ -23,8 +23,8 @@ def scroll(
     if w is None:
         w = clip.w
 
-    x_max = clip.w - w - 1
-    y_max = clip.h - h - 1
+    x_max = w - 1
+    y_max = h - 1
 
     def filter(get_frame, t):
         x = int(max(0, min(x_max, x_start + round(x_speed * t))))