-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModuleNotFound: No module named 'imageio_ffmpeg'
, or imageio v2.5.0 is breaking ffmpeg detection in config
#906
Comments
Thanks for this, and sorry I didnt react to the changes in imageio earlier. Would adding imageio_ffmpeg as a dependency solve the issue? |
No worries, That does help to prevent the exception, but including |
I understand that this is not ideal but this seems like a reasonable solution for now. It seems that imageio used to download FFMPEG only if needed but that is not the case anymore. It seems that imageio-ffmpeg is a nice and focused wrapper and moviepy could use much more of its api, but I don't have much time these days. |
imageio_ffmpeg is only for Python 3.4+ and doesn't work for 2.7 |
It appears that none of the workaround actually functions for me. I tried the moviepy + imagio 2.4.1 combi as well as the same + imagio_ffmpeg, as well as moviepy + imageio 2.5.0 + imageio_ffmpeg. Running on Windows within conda environment (Everything was installes from conda-forge). |
I believe I fixed it on Github at least for Python 3 (not sure). Can you try to pip install from this Github repo and let me know if it works?
If it does I will push a new version on PyPI asap. |
Yes this does the fix. I appreciate the quick response, saved me quite some time tonight |
Awesome. Could you confirm that you can run a minimal example? (this would reassure me that ffmpeg got downloaded properly and is usable by moviepy) I can't push to Pypi from my current location, but I will, first chance I get. |
Hope this helps. Created a fresh conda env (see pip freeze at top), installed from git and the run the sample form the website. Hope this is what you had in mind, if not let me know what specific sample / process you want me to run :) |
Looks good thanks! |
|
Let's lock imageio to a known good state until they fixed their ffmpeg integration. |
@das7pad From what I understand imageio is going to deprecate their old versions, meaning that they may point to deprecated URLs to download ffmpeg (ffmpeg didnt come with a wheel before, it was downloaded with |
The binaries are still there - they were yanked but then put up again. |
Not sure what to do, let's ask @almarklein: what would you advise regarding @das7pad's last 3 comments (case where imageio-ffmpeg doesnt get installed as a wheel by pip, so ffmpeg doesn't come packaged with it) |
Note: I opened an issue over in their repo: imageio/imageio-ffmpeg#12 |
Sorry to put y'all through this. I posted in a new issue #908 that should answer most questions. |
Looks like this was all sorted. |
Fixes yownas#41 by adding imageio-ffmpeg to extension requirements/dependencies. This is required due to some changes with moviepy's underlying imageio library, which has deprecated/removed the old autoinstallation method around 2019-ish, and as such moviepy is no longer capable of autoinstalling ffmpeg. See Zulko/moviepy#906 and Zulko/moviepy#908 for further details on the moviepy side. This does result in downloading ffmpeg on systems where it may already be installed, but it's a reasonably small download and on some systems (eg Ubuntu 22.04) moviepy 1.0.3 fails to pick up system ffmpeg anyway.
Expected Behavior
No exception thrown while running
Actual Behavior
Exception thrown:
Steps to Reproduce the Problem
Specifications
Cause
Recently
imageio
just updated to 2.5.0, deprecatedimageio.plugins.ffmpeg.get_exe()
and changed its behavior.Now the new
get_exe()
requires the new packageimageio_ffmpeg
, but is neither required bymoviepy
norimageio
(as they are not using that function anymore).This behavior has caused
moviepy
to stop working when trying to initialize the config.Temporary circumvention
FFMPEG_BINARY
to the absolute path offfmpeg
, orimageio
to~2.5.1
The text was updated successfully, but these errors were encountered: