Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple streams and metadata parsing to 'ffmpeg_parse_infos' #1466

Merged
merged 10 commits into from
Jan 21, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 18, 2021

  • Added support for metadata parsing to video.io.ffmpeg_reader.ffmpeg_parse_infos function.
  • Added support for multiple streams parsing to video.io.ffmpeg_reader.ffmpeg_parse_infos function (first step to fix in the future multiple input audio streams not getting merged #178).
  • Added support for chapters parsing to video.io.ffmpeg_reader.ffmpeg_parse_infos function.
  • Added -hide_banner option to ffmpeg command in ffmpeg_parse_infos to remove the ffmpeg banner for better performance.
  • Increased parsing speed of ffmpeg_parse_infos, all the parsing is done in a single loop. After chapters parsing added, the speed of both implementations is the same.
  • "video_rotation" field returned by ffmpeg_parse_infos is placed now at ["video_metadata"]["rotate"].
  • Removed test_ffmpeg_parse_infos_for_i926 because the same behaviour is checked in another test.

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@mondeja mondeja added enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. performance Speed/performance of code or individual functionality. labels Jan 18, 2021
@mondeja mondeja marked this pull request as draft January 18, 2021 14:32
@coveralls
Copy link

coveralls commented Jan 18, 2021

Coverage Status

Coverage increased (+0.7%) to 66.76% when pulling 8aeed0c on mondeja:ffmpeg_parse_infos-metadata into a378771 on Zulko:master.

@mondeja mondeja marked this pull request as ready for review January 18, 2021 14:46
@mondeja mondeja marked this pull request as draft January 18, 2021 14:59
@mondeja mondeja added the lib-FFmpeg Issues pertaining to dependency FFmpeg. label Jan 18, 2021
@mondeja

This comment has been minimized.

@tburrows13

This comment has been minimized.

@mondeja mondeja marked this pull request as ready for review January 18, 2021 21:16
@mondeja mondeja marked this pull request as draft January 19, 2021 10:59
@mondeja mondeja changed the title Add support for metadata parsing to 'ffmpeg_parse_infos' Add support for multiple streams and metadata parsing to 'ffmpeg_parse_infos' Jan 19, 2021
@mondeja mondeja marked this pull request as ready for review January 19, 2021 17:26
@mondeja

This comment has been minimized.

@mondeja mondeja marked this pull request as draft January 19, 2021 22:40
@mondeja mondeja marked this pull request as ready for review January 20, 2021 14:05
@mondeja mondeja marked this pull request as draft January 20, 2021 14:08
@mondeja mondeja marked this pull request as ready for review January 20, 2021 14:24
@mondeja
Copy link
Collaborator Author

mondeja commented Jan 21, 2021

I think this implementation is stable enough now, so I go ahead with the merge...

@mondeja mondeja removed the performance Speed/performance of code or individual functionality. label Jan 21, 2021
@mondeja mondeja merged commit 2482d13 into Zulko:master Jan 21, 2021
@mondeja mondeja mentioned this pull request Jan 23, 2021
@mondeja mondeja deleted the ffmpeg_parse_infos-metadata branch June 1, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. lib-FFmpeg Issues pertaining to dependency FFmpeg. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants