Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'loop' argument support writing GIFs with ffmpeg #1605

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jun 1, 2021

  • Add tests for moviepy.video.io.gif_writers::write_gif and document it.
  • Add documentation for moviepy.video.io.gif_writers::write_gif_with_tempfiles.
  • Allow to pass loop argument for both functions when program="ffmpeg" using loop FX.
  • Refactor tests removing test_Videos.py file (test moved to test_VideoClip.py).
  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@mondeja mondeja added enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. documentation Related to documentation in official project docs or individual docstrings. tests Related to individual tests in the test suite or running the test suite. labels Jun 1, 2021
@coveralls
Copy link

coveralls commented Jun 1, 2021

Coverage Status

Coverage increased (+0.06%) to 83.04% when pulling 6f207de on mondeja:write_gif-tests into 2aff1cf on Zulko:master.

@mondeja mondeja merged commit ad1177e into Zulko:master Jun 1, 2021
@mondeja mondeja deleted the write_gif-tests branch June 1, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation in official project docs or individual docstrings. enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants