Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress_bar option to write_images_sequence #300

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Add progress_bar option to write_images_sequence #300

merged 1 commit into from
Apr 11, 2017

Conversation

achalddave
Copy link
Contributor

No description provided.

tburrows13
tburrows13 approved these changes Feb 16, 2017
View reviewed changes
Copy link
Collaborator

@tburrows13 tburrows13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Mar 1, 2017
Closed
Closed
@tburrows13
Copy link
Collaborator

I'll test this, and merge if successful

@tburrows13 tburrows13 self-assigned this Mar 2, 2017
@mbeacom mbeacom added this to the Release v0.2.3.2 milestone Apr 5, 2017
@mbeacom mbeacom added the enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. label Apr 5, 2017
@mbeacom
Copy link
Collaborator

mbeacom commented Apr 5, 2017

@Gloin1313 Do you think this is good to go for the next release?

@tburrows13
Copy link
Collaborator

Sorry, I still haven't tested it yet... I will get round to it.

@tburrows13
Copy link
Collaborator

This does what is says. When using write_images_sequence, setting the parameter fps to anything other than 1, the progress bar behaved a little weirdly, but that was nothing to do with this PR.

@tburrows13 tburrows13 closed this Apr 8, 2017
@tburrows13 tburrows13 reopened this Apr 11, 2017
@tburrows13
Copy link
Collaborator

Oops, sorry. Just realised I had closed this, not merged it!

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0190bea on achalddave:progress_bar_write_images_sequence into ** on Zulko:master**.

3 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0190bea on achalddave:progress_bar_write_images_sequence into ** on Zulko:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0190bea on achalddave:progress_bar_write_images_sequence into ** on Zulko:master**.

@coveralls
Copy link

coveralls commented Apr 11, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 0190bea on achalddave:progress_bar_write_images_sequence into ** on Zulko:master**.

@tburrows13 tburrows13 merged commit b2001d2 into Zulko:master Apr 11, 2017
@tburrows13 tburrows13 added feature New addition to the API i.e. a new class, method or parameter. and removed enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. labels Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zulko Zulko Zulko approved these changes

@tburrows13 tburrows13 tburrows13 approved these changes

Assignees

@tburrows13 tburrows13

Labels
feature New addition to the API i.e. a new class, method or parameter.
Projects
None yet
Milestone
Release v0.2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@achalddave @tburrows13 @mbeacom @coveralls @Zulko