-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #354 #355
Fix issue #354 #355
Conversation
Ignore this comment, I posted the wrong code in the wrong issue.. sorry!
Am I overlooking something? Can someone else replicate my results? |
@Earney I haven't tested this, but are you saying you're still getting the error originally described by @groundflyer in #354? |
I'm not sure if the fix does anything. I do not see a difference in the output file "test.mp4". I thought I'd let @Zulko take a look. Maybe I'm overlooking something. |
@Earney I think the commit wasn't supposed to change the output file, but to get rid of an error. If the error can't be reproduced with the current code (minus the fix), maybe the issue is not valid anymore. |
My bad guys.. I posted the wrong set of code here about 10 days ago. The pull request does solve the issue for the problem in #354 . should we look at merging this? |
Or is the |
the |
@Earney At first I thought you were referring to someone because of the @ sign. Would you consider using backticks for code bits so they can be better differentiated from normal text? I know it's a bit more work to type messages that way but it improves their readability a lot. |
so you mean |
@Earney Yes!! (: |
I've finally figured out what is going on. Because TextClip inherits from ImageClip, and by default transparent = true, ImageClip will create a mask at class instantiation. Since the duration is not known at this time, the duration is set to none. There are a few solutions. One, when someone sets the duration of the clip, we could also set the duration of the mask. but if the mask gets updated (or replaced) we would need to reset the duration as well. The second option is to check that the masked duration is correct before we use it, which is similar to what this PR is doing. What method do people recommend? |
I'm currently leaning toward doing what this pull request does. In each fx, setting the |
This should fix #354