-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix YouTube embeds in docs #446
Conversation
Replaces AS3 objects with iframes and gets rid of mixed content (http urls in https site). |
I'm not sure I understand what the problem is, the videos in the gallery work fine for me in Firefox and Chrome, is there a problem on some other browsers ? Are iframes the standard way of embedding youtube videos ? |
For me, the videos don't show in either browser + when opening the local versions of the files, I'm additionally experiencing the problem described by @COLABORATI in #304 (I'm prompted to download the files). From the YouTube docs:
|
From Chrome's console: I'm also getting warnings for images, but apparently browsers aren't as strict about those, so they still show up. |
I have no idea why the videos show for you, @Zulko, because they really shouldn't. Perhaps different security settings? Maybe you allowed mixed content for your docs at some point (if that is even an option)? |
(My browsers default to the secure version of the docs pages... as they should.) |
I'm also getting the download prompts on mobile. Have you tried opening the docs with a browser you haven't used for development? (I'm not sure if/how being logged in could additionally affect this.) |
Just leaving a note here that @Zulko approved this PR on Gitter. |
Awesome!.. Lets merge this puppy then! :) |
Fixes #304, renders #342 + #343 invalid.