Fix FFMPEG_VideoReader.get_frame() #648
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.pos
inFFMPEG_VideoReader
isn't updated when a frame is read withFFMPEG_VideoReader.read_frame()
. This causesFFMPEG_VideoReader.get_frame()
to fail if seeking backwards becauseself.pos
is never greater than the calculated new position (if seeking backwards to any other time than 0.)