Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use input seeking in ffmpeg_extract_subclip, not output seeking #670

Closed
wants to merge 1 commit into from
Closed

Use input seeking in ffmpeg_extract_subclip, not output seeking #670

wants to merge 1 commit into from

Conversation

scrpy
Copy link

@scrpy scrpy commented Nov 20, 2017 •
edited
Loading

ffmpeg_extract_subclip should not decode the frames preceding the start of the desired subclip, as this is slow. Input seeking makes more sense here than output seeking. See seeking (ffmpeg wiki).

@coveralls
Copy link

coveralls commented Nov 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 57.202% when pulling 15fb689 on landogardner:master into a744df1 on Zulko:master.

@tburrows13 tburrows13 added refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. and removed refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. labels Nov 28, 2017
@scrpy
Copy link
Author

scrpy commented Aug 6, 2019

Superseded by #882

@scrpy scrpy closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scrpy @coveralls @tburrows13