Merge pull request #25 from ZupIT/develop

Refactor 2.0

.github/workflows/coverage.yml

@@ -0,0 +1,12 @@
+name: Coverage
+on:
+  pull_request:
+    branches: ["**"]
+jobs:
+  coverage:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2
+      - name: coverage
+        run: make coverage

.github/workflows/lint.yml

@@ -0,0 +1,11 @@
+name: Lint
+on:
+  pull_request:
+    branches: ["**"]
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: lint
+        run: make lint

.github/workflows/security.yml

@@ -0,0 +1,11 @@
+name: Security
+on:
+  pull_request:
+    branches: ["**"]
+jobs:
+  security:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: security
+        run: make security

.github/workflows/tests.yml

@@ -0,0 +1,12 @@
+name: Test
+on:
+  pull_request:
+    branches: ["**"]
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2
+      - name: test
+        run: make test

.gitignore

@@ -9,8 +9,11 @@
 # Test binary, built with `go test -c`
 *.test
 
+.horusec
+
 # Output of the go coverage tool, specifically when used with LiteIDE
 *.out
+*tmp*
 
 # Dependency directories
 vendor/

.golangci.yml

@@ -1,4 +1,43 @@
 linters-settings:
+  depguard:
+    list-type: blacklist
+    packages:
+    packages-with-error-message:
+  dupl:
+    threshold: 100
+  funlen:
+    lines: 15
+    statements: 10
+  gci:
+    local-prefixes: github.com/ZupIT/horusec-admin
+  goconst:
+    min-len: 2
+    min-occurrences: 2
+  gocritic:
+    enabled-tags:
+      - diagnostic
+      - experimental
+      - opinionated
+      - performance
+      - style
+    disabled-checks:
+      - dupImport
+      - octalLiteral
+      - whyNoLint
+      - wrapperFunc
+      - evalOrder
+      - unnamedResult
+  gocyclo:
+    min-complexity: 10
+  goimports:
+    local-prefixes: github.com/ZupIT/horusec-admin
+  golint:
+    min-confidence: 0
+  gomnd:
+    settings:
+      mnd:
+        # don't include the "operation" and "assign"
+        checks: argument,case,condition,return
   govet:
     check-shadowing: true
     settings:
@@ -8,106 +47,90 @@ linters-settings:
           - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf
           - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
           - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
-  golint:
-    min-confidence: 0.8
-  gocyclo:
-    min-complexity: 5
+  lll:
+    line-length: 120
   maligned:
     suggest-new: true
-  dupl:
-    threshold: 100
-  goconst:
-    min-len: 2
-    min-occurrences: 2
-  depguard:
-    list-type: blacklist
-    packages:
-      # logging is allowed only by logutils.Log, logrus
-      # is allowed to use only in logutils package
-      - github.com/sirupsen/logrus
-    packages-with-error-messages:
-      github.com/sirupsen/logrus: "logging is allowed only by logutils.Log"
   misspell:
     locale: US
-  lll:
-    line-length: 120
-  goimports:
-    local-prefixes: github.com/golangci/golangci-lint
-  gocritic:
-    enabled-tags:
-      - opinionated
-      - experimental
-      - diagnostic
-      - style
-      - performance
-    disabled-checks:
-      - evalOrder
-      - wrapperFunc
-      - unnamedResult
-      - octalLiteral
-      - dupImport
-  funlen:
-    lines: 15
-    statements: 10
+  nolintlint:
+    allow-leading-space: true # don't require machine-readable nolint directives (i.e. with no leading space)
+    allow-unused: false # report any unused nolint directives
+    require-explanation: false # don't require an explanation for nolint directives
+    require-specific: false # don't require nolint directives to be specific about which linter is being skipped
 
 linters:
   # please, do not use `enable-all`: it's deprecated and will be removed soon.
   # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
   disable-all: true
   enable:
-    - dogsled
+    - bodyclose
     - deadcode
     - depguard
-    - bodyclose
-    - funlen
-    - errcheck
+    - dogsled
     - dupl
-    - gocritic
+    - errcheck
+    - exportloopref
+    - exhaustive
+    - funlen
     - gochecknoinits
     - goconst
-    - gofmt
+    - gocritic
     - gocyclo
-    - gosec
+    - gofmt
+    - goimports
     - golint
-    - ineffassign
+    - gomnd
+    - goprintffuncname
+    - gosec
     - gosimple
     - govet
+    - ineffassign
     - lll
-    - interfacer
-    - nakedret
     - misspell
+    - nakedret
+    - noctx
+    - nolintlint
+    - rowserrcheck
     - staticcheck
-    - scopelint
-    - stylecheck
     - structcheck
-    - unconvert
+    - stylecheck
     - typecheck
-    - unused
+    - unconvert
     - unparam
-    - whitespace
+    - unused
     - varcheck
+    - whitespace
+
+  # don't enable:
+  # - asciicheck
+  # - scopelint
+  # - gochecknoglobals
+  # - gocognit
+  # - godot
+  # - godox
+  # - goerr113
+  # - interfacer
+  # - maligned
+  # - nestif
+  # - prealloc
+  # - testpackage
+  # - revive
+  # - wsl
+
+issues:
+exclude-rules:
+  - linters:
+      - lll
+    source: "^// "
 
 run:
   skip-dirs:
     - vendor/
     - examples/
     - tmp
     - e2e/
-    - pkg/client
-    - pkg/api
+    - pkg
   skip-files:
     - .*_test.go
     - .*_mock.go
-
-issues:
-  exclude-rules:
-    - linters:
-        - lll
-      source: "^// "
-
-# golangci.com configuration
-# https://github.com/golangci/golangci/wiki/Configuration
-service:
-  golangci-lint-version: v1.21.0 # use the fixed version to not introduce new linters unexpectedly
-  prepare:
-    - echo "here I can run custom commands, but no preparation needed for this repo"

.semver.yaml

@@ -0,0 +1,4 @@
+alpha: 1
+beta: 0
+rc: 0
+release: v2.0.0