Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaks:chore - Adding improvements on leaks rules #1040

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

wiliansilvazup
Copy link
Contributor

@wiliansilvazup wiliansilvazup commented Mar 17, 2022

In this commit I changed to add Safe and Unsafe code
in all rules of the leaks. Reference from issue #630 and #1020.

Signed-off-by: Wilian Gabriel wilian.silva@zup.com.br

@gitguardian
Copy link

gitguardian bot commented Mar 17, 2022

⚠️ GitGuardian has uncovered 23 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
615391 AWS Keys 0eaacbd internal/services/engines/leaks/rules_test.go View secret
615400 Amazon MWS Token 0eaacbd internal/services/engines/leaks/rules_test.go View secret
615386 Square Token 0eaacbd internal/services/engines/leaks/rules_test.go View secret
1596062 Stripe Keys 0eaacbd internal/services/engines/leaks/rules_test.go View secret
1596063 Stripe Keys 0eaacbd internal/services/engines/leaks/rules_test.go View secret
615376 Generic High Entropy Secret 0eaacbd internal/services/engines/leaks/rules_test.go View secret
615380 Generic High Entropy Secret 0eaacbd internal/services/engines/leaks/rules_test.go View secret
1596064 Generic High Entropy Secret 0eaacbd internal/services/engines/leaks/rules_test.go View secret
1596065 Generic High Entropy Secret 0eaacbd internal/services/engines/leaks/rules_test.go View secret
615391 AWS Keys 0eaacbd internal/services/engines/leaks/samples.go View secret
615391 AWS Keys 0eaacbd internal/services/engines/leaks/samples.go View secret
615400 Amazon MWS Token 0eaacbd internal/services/engines/leaks/samples.go View secret
615400 Amazon MWS Token 0eaacbd internal/services/engines/leaks/samples.go View secret
615386 Square Token 0eaacbd internal/services/engines/leaks/samples.go View secret
615386 Square Token 0eaacbd internal/services/engines/leaks/samples.go View secret
1596062 Stripe Keys 0eaacbd internal/services/engines/leaks/samples.go View secret
1596063 Stripe Keys 0eaacbd internal/services/engines/leaks/samples.go View secret
1596062 Stripe Keys 0eaacbd internal/services/engines/leaks/samples.go View secret
1596063 Stripe Keys 0eaacbd internal/services/engines/leaks/samples.go View secret
615376 Generic High Entropy Secret 0eaacbd internal/services/engines/leaks/samples.go View secret
615380 Generic High Entropy Secret 0eaacbd internal/services/engines/leaks/samples.go View secret
615376 Generic High Entropy Secret 0eaacbd internal/services/engines/leaks/samples.go View secret
1596064 Generic High Entropy Secret 0eaacbd internal/services/engines/leaks/samples.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

In this commit I changed to add Safe and Unsafe code
in all rules of the leaks. Reference from issue #630 and #1020.

Signed-off-by: Wilian Gabriel <wilian.silva@zup.com.br>
@wiliansilvazup wiliansilvazup merged commit ae78215 into main Mar 23, 2022
@wiliansilvazup wiliansilvazup deleted the chore/improvements-leaks-rules branch March 23, 2022 13:30
wiliansilvazup added a commit that referenced this pull request Apr 6, 2022
In this commit I changed to add Safe and Unsafe code
in all rules of the leaks. Reference from issue #630 and #1020.

Signed-off-by: Wilian Gabriel <wilian.silva@zup.com.br>
(cherry picked from commit ae78215)
Signed-off-by: Wilian Gabriel <wilian.silva@zup.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant