Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps:chore - remove unused dependencies #852

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Conversation

matheusalcantarazup
Copy link
Contributor

Yeah, another PR removing unused dependencies

Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br

- What I did

- How to verify it

- Description for the changelog

Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
@iancardosozup
Copy link
Contributor

this type of PRs are getting repetitive, i was doing some research and found some ideas for this problem.

  1. Create a cronjob in actions to automatically runs go.mod tidy and open a PR just like renovate bot is doing (something like this but instead of pushing to main, creating a PR to main)
  2. Managing git pre commit hooks with pre-commit tool
  3. Create a step that fails the PR if current go.mod/go.sum have diffs after a go mod tidy run ( see this)

what do you guys think? anynone have a new idea? @wiliansilvazup @nathanmartinszup @matheusalcantarazup @lucasbrunozup @oliveirafelipezup

@matheusalcantarazup
Copy link
Contributor Author

this type of PRs are getting repetitive, i was doing some research and found some ideas for this problem.

  1. Create a cronjob in actions to automatically runs go.mod tidy and open a PR just like renovate bot is doing (something like this but instead of pushing to main, creating a PR to main)
  2. Managing git pre commit hooks with pre-commit tool
  3. Create a step that fails the PR if current go.mod/go.sum have diffs after a go mod tidy run ( see this)

what do you guys think? anynone have a new idea? @wiliansilvazup @nathanmartinszup @matheusalcantarazup @lucasbrunozup @oliveirafelipezup

I prefer the first option.

@nathanmartinszup
Copy link
Contributor

this type of PRs are getting repetitive, i was doing some research and found some ideas for this problem.

  1. Create a cronjob in actions to automatically runs go.mod tidy and open a PR just like renovate bot is doing (something like this but instead of pushing to main, creating a PR to main)
  2. Managing git pre commit hooks with pre-commit tool
  3. Create a step that fails the PR if current go.mod/go.sum have diffs after a go mod tidy run ( see this)

what do you guys think? anynone have a new idea? @wiliansilvazup @nathanmartinszup @matheusalcantarazup @lucasbrunozup @oliveirafelipezup

First and third option looks good to me, any of them or both together.

@matheusalcantarazup matheusalcantarazup merged commit 856913f into main Dec 8, 2021
@matheusalcantarazup matheusalcantarazup deleted the go-mod-tidy branch December 8, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants