language_detect:fix ignore files correctly on Windows #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
force-pushed
the
fix-language-detect-windows
branch
15 times, most recently
from
d0b00e3
to
d9c99d1
Compare
matheusalcantarazup
changed the title
Previously when checking which files should be ignored by analysis on Windows the directories patterns was not working properly, this is because we was expecting that these paths would be always Unix like paths so when a user set a path `**/tests/**` we can not ignore the tests directory on Windows since the path would be `**\\tests\\**`. This commit fix this issue converting all paths and all patterns to Unix like paths before checking if should be ignored. Now `**/tests/**` would match both `foo/bar/tests` and `foo\\bar\\tests`. If the user set the pattern to use Windows slashes like `**\\tests\\**`, this will work correctly only on Windows, so it is recommend that users should always use the Unix slashes when configuring patterns that should be ignored by analysis. Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
fix-language-detect-windows
branch
from
d9c99d1
to
012ea7b
Compare
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
nathanmartinszup
approved these changes
Dec 8, 2021
i think this should be added to the docs |
Definitely agree. |
wiliansilvazup
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when checking which files should be ignored by analysis on
Windows the directories patterns was not working properly, this is
because we was expecting that these paths would be always Unix like
paths so when a user set a path
**/tests/**we can not ignore thetests directory on Windows since the path would be
**\\tests\\**.This commit fix this issue converting all paths and all patterns to Unix
like paths before checking if should be ignored. Now
**/tests/**wouldmatch both
foo/bar/testsandfoo\\bar\\tests.If the user set the pattern to use Windows slashes like
**\\tests\\**,this will work correctly only on Windows, so it is recommend that users
should always use the Unix slashes when configuring patterns that should
be ignored by analysis.
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog