formatters:fix - invalid work dir path on Windows #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
force-pushed
the
fix-get-files-subpath
branch
12 times, most recently
from
eeb64ef
to
548659d
Compare
matheusalcantarazup
changed the title
matheusalcantarazup
force-pushed
the
fix-get-files-subpath
branch
2 times, most recently
from
b83c336
to
60bd7d4
Compare
Previously when we were running on Windows we was setting a Windows path
as a work dir inside a Docker container. For example, we start the
analysis, and we try to find a path that contains go.mod files, we found
the path C:\user\some\path and we was using this path (with Windows
slashes) as a work dir on Docker, so when the command try to access this
path (cd some\path) we was getting errors.
This commit fix this issue converting any path to Unix path before
replacing the {{WORK_DIR}} of command.
Some tests of formatter was changed to expected that any path used on
{{WORK_DIR}} should be a Unix like path.
This commit also make some improvements on `utils/file` private
functions, resolving a TODO by refactoring the function to use a better
approach to get the relative directory of a file path. Some functions
was renamed to make more clear what they are doing and new debug logging
was added to inform the path that the searched files was founded.
Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
fix-get-files-subpath
branch
from
60bd7d4
to
43bbe90
Compare
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
nathanmartinszup
approved these changes
Dec 14, 2021
iancardosozup
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when we were running on Windows we was setting a Windows path
as a work dir inside a Docker container. For example, we start the
analysis, and we try to find a path that contains go.mod files, we found
the path C:\user\some\path and we was using this path (with Windows
slashes) as a work dir on Docker, so when the command try to access this
path (cd some\path) we was getting errors.
This commit fix this issue converting any path to Unix path before
replacing the {{WORK_DIR}} of command.
Some tests of formatter was changed to expected that any path used on
{{WORK_DIR}} should be a Unix like path.
This commit also make some improvements on
utils/fileprivatefunctions, resolving a TODO by refactoring the function to use a better
approach to get the relative directory of a file path. Some functions
was renamed to make more clear what they are doing and new debug logging
was added to inform the path that the searched files was founded.
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog