brakeman:chore - improve tests asserts and code cleaning #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
force-pushed
the
brakeman-improve-tests
branch
2 times, most recently
from
ec9ef9d
to
108f08f
Compare
Previously the tests was not asserting that we was correctly parsing the output from brakeman and we was only checking that vulnerabilities was being added on analysis without checking if their contents was correctly. This commit add some new checks to assert that all vulnerabilities founded by brakeman is parsed correctly. Updates #718 Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
brakeman-improve-tests
branch
from
108f08f
to
d7f1161
Compare
iancardosozup
approved these changes
Dec 16, 2021
wiliansilvazup
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the tests was not asserting that we was correctly parsing the
output from brakeman and we was only checking that vulnerabilities was
being added on analysis without checking if their contents was
correctly.
This commit add some new checks to assert that all vulnerabilities
founded by brakeman is parsed correctly.
Updates #718
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog