formatters:chore - remove unused methods from IService #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the `GetCommitAuthor` was just being used internally by IService implementation there's no reason to keep this method, and as pointed by @iancardosozup, on `GetProjectPathWithWorkDir` docs, their usage can be simple changed by a `filepath.Join` call, so this method was removed too. Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
nathanmartinszup
approved these changes
Jan 6, 2022
iancardosozup
approved these changes
Jan 6, 2022
nathanmartinszup
pushed a commit
that referenced
this pull request
Apr 4, 2022
Since the `GetCommitAuthor` was just being used internally by IService implementation there's no reason to keep this method, and as pointed by @iancardosozup, on `GetProjectPathWithWorkDir` docs, their usage can be simple changed by a `filepath.Join` call, so this method was removed too. Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br> (cherry picked from commit 802f0c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
GetCommitAuthorwas just being used internally byIService implementation there's no reason to keep this method, and as
pointed by @iancardosozup, on
GetProjectPathWithWorkDirdocs, theirusage can be simple changed by a
filepath.Joincall, so this method wasremoved too.
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog