engine/java:chore - updating log4j rule to avoid false positives #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanmartinszup
requested review from
wiliansilvazup,
matheusalcantarazup,
lucasbrunozup and
iancardosozup
as code owners
Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
nathanmartinszup
force-pushed
the
chore/hs-java-150
branch
from
3293564
to
7cdf4c2
Compare
wiliansilvazup
approved these changes
Feb 10, 2022
wiliansilvazup
added
kind/improvement
matheusalcantarazup
approved these changes
Feb 10, 2022
|
Can we add a test case for this? |
The change on the test case |
nathanmartinszup
added a commit
that referenced
this pull request
Feb 10, 2022
Signed-off-by: Nathan Martins <nathan.martins@zup.com.br> (cherry picked from commit 6abcc37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nathan Martins nathan.martins@zup.com.br
- What I did
- How to verify it
- Description for the changelog