Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format OpenWrt Makefile and fix CMakeLists #23

Merged
merged 3 commits into from
Jun 16, 2021
Merged

format OpenWrt Makefile and fix CMakeLists #23

merged 3 commits into from
Jun 16, 2021

Conversation

1715173329
Copy link
Contributor 

Tianling Shen (3):
      style: format OpenWrt Makefile
      fix: remove obsolete targets in CMakeLists
      fix: remove compile warnings

 CMakeLists.txt | 12 ++----------
 Makefile       | 23 ++++++++---------------
 src/ua2f.c     |  2 +-
 3 files changed, 11 insertions(+), 26 deletions(-)

@1715173329
style: format OpenWrt Makefile
402d369 
Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
@1715173329
fix: remove obsolete targets in CMakeLists
00f5bba 
Fixes: 661334b ("chore: remove reference")

Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
@1715173329
fix: remove compile warnings
577dc0d 
Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
@Zxilly
Copy link
Owner

Zxilly commented Jun 16, 2021

Thanks a lot!

@Zxilly Zxilly merged commit 8b6739a into Zxilly:master Jun 16, 2021
@1715173329 1715173329 deleted the fixes branch June 16, 2021 23:02
1715173329
1715173329 commented Jun 16, 2021
View reviewed changes
Makefile Show resolved Hide resolved
@1715173329 1715173329 mentioned this pull request Jun 17, 2021
Merged
Zxilly pushed a commit that referenced this pull request Jun 17, 2021
@1715173329
build(Makefile): correct build path (#24)
c25f5e7 
On OpenWrt, buildbot will copy all files from src to builddir root.

Fixes: 8b6739a ("build: format OpenWrt Makefile and fix CMakeLists (#23)")

Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zxilly Zxilly Zxilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1715173329 @Zxilly