-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asteroid plot edges #170
Asteroid plot edges #170
Conversation
Thanks for the PR! Ah, yes, the line hover doesn't work on 2D scatters in Plotly AFAIK. If you're really desparate for it, one solution I've seen is to add transparent nodes on the midpoint of each line. https://stackoverflow.com/questions/46037897/line-hover-text-in-plotly |
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 40.27% 48.96% +8.69%
==========================================
Files 48 74 +26
Lines 2811 4254 +1443
==========================================
+ Hits 1132 2083 +951
- Misses 1679 2171 +492
Continue to review full report at Codecov.
|
@avivko Happy to merge unless you want to try your hand at the edge labelling? |
Nah, it's fine. but I decided to add an option to display a legend that groups the edges by kind. This way you can click certain edge kinds away, which is neat/useful in my opinion. I'll push it in a jiffy. |
@a-r-j Also, I see that one of your tests fails because of the ye old broken conda environment file.
|
Great - that's a really nice solution. Re the conda env, I'll check it out in another PR. Thanks for the contribution! Appreciate the effort :) |
Kudos, SonarCloud Quality Gate passed! |
Reference Issues/PRs
Fixes #167
Note: hoovering over the edges does not show the edge kind. @a-r-j Feel free to have a look at it!
What does this implement/fix? Explain your changes
What testing did you do to verify the changes in this PR?
Ran it on JN and got a plot with edges without an error (attached)