Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster file loading bug in pdb_data.py #396

Merged
merged 3 commits into from
May 19, 2024
Merged

Conversation

amorehead
Copy link
Contributor

@amorehead amorehead commented May 19, 2024

Reference Issues/PRs

Fixes a cluster file loading bug in pdb_data.py,

What does this implement/fix? Explain your changes

The PDBManager's from_fasta() function already prefixes its input filename argument with self.root_dir /, so one needs to remove this prefix in functions that call from_fasta() (to avoid a double prefix that causes a file not found error).

What testing did you do to verify the changes in this PR?

I tested this change locally.

Pull Request Checklist

  • Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
  • Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
  • Checked for style issues by running black . and isort .

Copy link

sonarcloud bot commented May 19, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@a-r-j a-r-j merged commit 44d8692 into a-r-j:master May 19, 2024
16 of 17 checks passed
@amorehead amorehead deleted the patch-1 branch May 19, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants