Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix greater than/less than operations in pdb_manager #408

Merged
merged 7 commits into from
Sep 18, 2024

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Aug 15, 2024

Reference Issues/PRs

What does this implement/fix? Explain your changes

Greater than / less than comparisons in oligomer selection in PDBManager are switched to greater than or less than.

What testing did you do to verify the changes in this PR?

Pull Request Checklist

  • Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
  • Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
  • Checked for style issues by running black . and isort .

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.23%. Comparing base (8123f42) to head (c780734).
Report is 184 commits behind head on master.

Files with missing lines Patch % Lines
graphein/ml/datasets/pdb_data.py 0.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   40.27%   45.23%   +4.96%     
==========================================
  Files          48      113      +65     
  Lines        2811     8188    +5377     
==========================================
+ Hits         1132     3704    +2572     
- Misses       1679     4484    +2805     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 17, 2024

@a-r-j a-r-j merged commit 17b9d0b into master Sep 18, 2024
31 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants