Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace gcd implementation with dart:core's #23

Merged
merged 1 commit into from
Dec 21, 2019
Merged

Replace gcd implementation with dart:core's #23

merged 1 commit into from
Dec 21, 2019

Conversation

rapzo
Copy link
Contributor

@rapzo rapzo commented Dec 21, 2019

No description provided.

a14n
a14n approved these changes Dec 21, 2019
View reviewed changes
Copy link
Owner

@a14n a14n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@a14n a14n merged commit 2a2a28a into a14n:master Dec 21, 2019
@a14n
Copy link
Owner

a14n commented Dec 21, 2019

published in version 0.3.7

@rapzo
Copy link
Contributor Author

rapzo commented Dec 21, 2019

Than you!

@rapzo rapzo deleted the refactor/replace-gcd branch December 21, 2019 16:53
@krispypen
Copy link
Contributor

this was custom implementation was because of the gcd method in dart is too slow, I don't think the issues is fixed yet in dart dart-lang/sdk#46180 ?

@a14n
Copy link
Owner

a14n commented Mar 24, 2022

This PR had been revert with a935513. I haven't test again recently but the sdk issue you mentioned is still open so I don't expect perf changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a14n a14n a14n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rapzo @a14n @krispypen