mostly cosmetic changes wrt. storage layout handling #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `--custom-storage-layout` -> `--storage-layout=generic` (I think it's a bit more intuitive and future proof if we want to add more models in the future) - rename CustomStorage to GenericStorage - set the storage model at SEVM creation time, rather than on every store/load
daejunpark
reviewed
Sep 15, 2023
| if self.options["custom_storage_layout"]: | ||
| return CustomStorage.load(ex, addr, loc) | ||
| else: | ||
| return SolidityStorage.load(ex, addr, loc) |
There was a problem hiding this comment.
oh, is it that a new class instance is created whenever a class method is called?
There was a problem hiding this comment.
no, it just passes the class reference. Here is my reasoning for moving this logic to the SEVM constructor:
- it is a tiny bit more efficient to only check the
"custom_storage_layout"at config time (rather than every time we process an sload/sstore) - it reduces code duplication a wee bit
- it feels more conceptually clean: you configure the SEVM class with a specific storage model, and then that SEVM instance will always work with that storage model
daejunpark
approved these changes
Sep 15, 2023
This was referenced Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--custom-storage-layout->--storage-layout=generic(I think it's a bit more intuitive and future proof if we want to add more models in the future)