[Feature/#270] Support vm.getBlockNumber cheatcode #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update cheatcode handler to recognize and proceses the getBlockNumber() * Add solidity test code to ensure the getBlockNumber() cheatcode works as expected
* Update submodule reference commits for forge-std, multicaller, openzeppelin-contracts, solady and solmate * Modify examples/simple/remappings.txt to include new paths for openzeppelin-contract, ds-test and forge-std
daejunpark
reviewed
Jul 16, 2024
There was a problem hiding this comment.
thanks for this!
if it is necessary to update the forge-std submodule, this can be merged only after #323.
also, to make the scope of changes clearer, i'd suggest not updating irrelevant submodules in this pr.
additional comments below.
* Add newline character at the end of the blocknumer.t.sol file * Remove library dependencies at examples/simple/remappings.txt
|
@daejunpark |
|
thanks! we will merge this after #323. |
daejunpark
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Type
Description
This PR introduces supporting vm.getBlockNumber() cheat code. Key changes include the
getBlockNumber()cheat code function to retrieve the current block number and adding solidity test contract to verify the functionality ofgetBlockNumber.Related Issues
This PR resolves #270
Changes
Cheat Code Implementation
getBlockNumber()in the cheat code logic.Update submodules
Tests