Update jsonrpsee to 0.18.0 #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After v0.18.0, jsonrpsee::core::Error was removed. These are just naive changes to get it to compile. See: https://github.com/paritytech/jsonrpsee/releases/tag/v0.18.0
Wiz Scan Summary
|
|
Closing in favor of #374 |
Mmagkooo
approved these changes
Oct 7, 2024
Mmagkooo
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #370.
This is the first breaking change I found when trying to update jsonrpsee. The fix is the quickest I could do. I feel it could be nicer, but I haven't written any rust in a couple of years. If fixes are needed, I can help with some patient guidance :)
This still doesn't let us update ring, so this branch still fails to compile in risc-v.