Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF7 compat & Some cleanings #387

Merged
merged 10 commits into from
Jan 3, 2024
Merged

SF7 compat & Some cleanings #387

merged 10 commits into from
Jan 3, 2024

Conversation

webda2l
Copy link
Member

@webda2l webda2l commented Jan 2, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (ca3bf7b) 70.04% compared to head (b1fff14) 70.35%.

Files Patch % Lines
src/Form/Type/TranslatedEntityType.php 0.00% 5 Missing ⚠️
src/Form/Type/TranslationsLocalesSelectorType.php 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #387      +/-   ##
============================================
+ Coverage     70.04%   70.35%   +0.31%     
  Complexity       73       73              
============================================
  Files            12       12              
  Lines           237      253      +16     
============================================
+ Hits            166      178      +12     
- Misses           71       75       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webda2l webda2l changed the title Refresh SF7 compat & Some cleanings Jan 3, 2024
@webda2l webda2l marked this pull request as ready for review January 3, 2024 11:26
@webda2l webda2l merged commit 44fbcae into master Jan 3, 2024
16 checks passed
@webda2l webda2l deleted the refresh branch January 3, 2024 11:27
@webda2l webda2l mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants