Fix stack overflow in HTML generation #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanBlanchard
force-pushed
the
fix/html/stack-overflow
branch
from
13597a1 to
214828d
Compare
|
Ok, the CI has the same behavior as on the |
- mitigate stack overflow risk for big files
AllanBlanchard
force-pushed
the
fix/html/stack-overflow
branch
from
214828d to
c9ea1a1
Compare
|
Thank you! This will be included in the next release. |
aantron
pushed a commit
that referenced
this pull request
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a stack overflow when running bisect on the code base of Frama-C. This PR replaces a try catch with a match exception to avoid stacking try contexts.
I would probably be better to make the function tail recursive though, but I don't know when I can do it.Ok, I miss-used the[@tailcall], now it is tailrec.