Adjust SVG attributes irrespective of their namespace #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I am using tyxml and ran into the same issue as ocsigen/tyxml#307, but with the attribute
viewBox
instead. It only occurs with the ppx so I looked into thehtml_parser
as suggested by @mooreryan in the issue (thanks!).As far as I can tell, this is what happens:
<svg>
tag and parses it in the SVG namespace here.I don't know enough about namespaces and the use cases of this library, but from my POV there are two fixes:
svg
element implicitly.adjust_svg_attributes
because the decision to adjust attribute names is already made by the caller.This PR adds a test with my own use case and passes it by choosing option 2. I also built and tested the
tyxml
repository against this PR which works fine.