Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow Tabs on single line comments too #25

Closed
bekorn opened this issue Jan 16, 2018 · 3 comments
Closed

Feature Request: Allow Tabs on single line comments too #25

bekorn opened this issue Jan 16, 2018 · 3 comments
Assignees

Comments

@bekorn
Copy link
Contributor

bekorn commented Jan 16, 2018

I commonly put a tab after my comment delimiter and surprised this is not supported.

// start by finding the delimiter (//, --, #, ') with an optional space

Is there any problem if there would be a tab between the delimiter and the comment?

@aaron-bond
Copy link
Owner

Nope, this is totally doable. Just an oversight. I'll get something in there for you by this weekend :)

@aaron-bond aaron-bond self-assigned this Jan 16, 2018
@bekorn
Copy link
Contributor Author

bekorn commented Jan 16, 2018

Thanks 😄 Actually I think I can do it and pr if you want. As I understand the only thing I have to change is this regex's second group:

this.expression = "(" + this.delimiter.replace(/\//ig, "\\/") + ")+( )?";

@aaron-bond
Copy link
Owner

Yeah you're exactly right about the regex. That's what I'd change too. Feel free to set up a PR if you have time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants