-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling the “--status” flag with a LOGBASE #44
Comments
They do both work, and all of these should work, but I think some make more sense than the others. These make sense using environment variables.
Putting the config first in a historic fashion makes sense, but it's odd syntax.
This really doesn't make sense at all. It works, but is really awful syntax. The config looks like an argument to the status flag.
If you want to pass the config to the command you should use an option for both the config and status.
You can also mix and match |
In light of the discussion in #44, option parsing needs to be more strict. We shouldn't allow an orphaned config at the end of a line that looks like an option to another argument. This commit ensures that the config is either passed FIRST, or via the -c/--config option. It also does full argument validation before calling showStatus or showHelp.
We shouldn't allow dangling configs, I've fixed this in #45 |
In light of the discussion in #44, option parsing needs to be more strict. We shouldn't allow an orphaned config at the end of a line that looks like an option to another argument. This commit ensures that the config is either passed FIRST, or via the -c/--config option. It also does full argument validation before calling showStatus or showHelp.
Since the FreeBSD port installs the application to $PATH, what’s the best way to call the “--status” command due to the fact that the default $PATH is not where the “config.sh” or the “logs” directory are stored?
You could do “LOGBASE=/path/to/logs zfs-replicate --status” or “zfs-replicate -s /path/to/config.sh”
Both work.
The text was updated successfully, but these errors were encountered: