Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support struct aot #1020

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

yhd4711499
Copy link

No description provided.

@yhd4711499
Copy link
Author

Appveyor failed to build but no error message was shown. A rebuild should be triggered perhaps?

@EdwardCooke
Copy link
Collaborator

I think there’s a bug in the UI. At least on mobile. For the past few days I’ve had to download the log and view it from that.

C:\projects\yamldotnet\YamlDotNet\Serialization\SerializerBuilder.cs(691,13): error IDE0074: Use compound assignment (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0074) [C:\projects\yamldotnet\YamlDotNet\YamlDotNet.csproj::TargetFramework=net47]
[00:02:16] C:\projects\yamldotnet\YamlDotNet\Serialization\DeserializerBuilder.cs(488,13): error IDE0074: Use compound assignment (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0074) [C:\projects\yamldotnet\YamlDotNet\YamlDotNet.csproj::TargetFramework=net47]

@yhd4711499
Copy link
Author

Should I fix these "Use compound assignment" errors in current branch?

@EdwardCooke
Copy link
Collaborator

Yes please.

@yhd4711499
Copy link
Author

All fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants