Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed return from aToken() function from IERC20 to address #56

Closed

Conversation

pavelvm5
Copy link
Contributor

@pavelvm5 pavelvm5 commented Sep 19, 2024

I suggest returning address rather than IERC20, as this will help avoid problems if different incompatible interfaces are used (or the same interface can be from different sources, which will be perceived as different).

@pavelvm5 pavelvm5 changed the title Changed return from aToken() function to addr Changed return from aToken() function from interface to address Sep 19, 2024
@pavelvm5 pavelvm5 changed the title Changed return from aToken() function from interface to address Changed return from aToken() function from IERC20 to address Sep 19, 2024
kyzia551
kyzia551 previously approved these changes Sep 20, 2024
sakulstra
sakulstra previously approved these changes Sep 26, 2024
kyzia551
kyzia551 previously approved these changes Sep 26, 2024
@sakulstra sakulstra changed the base branch from main to v3.2.0 September 26, 2024 12:52
@sakulstra sakulstra changed the base branch from v3.2.0 to main September 26, 2024 12:53
@sakulstra sakulstra dismissed kyzia551’s stale review September 26, 2024 12:53

The base branch was changed.

@sakulstra sakulstra closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants