Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes solc version of contracts #920

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

miguelmtzinf
Copy link
Contributor

@miguelmtzinf miguelmtzinf commented Oct 4, 2023

Closes #919

In general, the reasoning is the following:

  1. interfaces and libraries to ^0.8.0
  2. dependencies and mocks to ^0.8.0
  3. contracts to ^0.8.10

Here is how it looks now:

  • dependencies/chainlink to ^0.8.0
  • dependencies/gnosis/GPv2SafeERC20 to ^0.8.0
  • dependencies/openzeppelin/contracts to ^0.8.0
  • dependencies/openzeppelin/upgradeability to ^0.8.0
  • dependencies/weth to ^0.8.0
  • deployments to ^0.8.0
  • flashloan/interfaces to ^0.8.0
  • flashloan/base to ^0.8.0
  • interfaces to ^0.8.0
  • misc/interfaces to ^0.8.0
  • misc to * ^0.8.10
  • mocks to ^0.8.0
  • protocol/configuration to ^0.8.10
  • protocol/libraries/aave-upgradeability to ^0.8.0
  • protocol/libraries/configuration to ^0.8.0
  • protocol/libraries/helpers to ^0.8.0
  • protocol/libraries/logic to ^0.8.10
  • protocol/libraries/math to ^0.8.0
  • protocol/libraries/types to ^0.8.0
  • protocol/pool to ^0.8.10
  • protocol/tokenization to ^0.8.10

@height
Copy link

height bot commented Oct 4, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (27a6d5c) 99.61% compared to head (2bafef0) 99.65%.

❗ Current head 2bafef0 differs from pull request most recent head 017eb3c. Consider uploading reports for the commit 017eb3c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
+ Coverage   99.61%   99.65%   +0.04%     
==========================================
  Files          46       46              
  Lines        2327     2327              
  Branches      426      348      -78     
==========================================
+ Hits         2318     2319       +1     
+ Misses          9        8       -1     
Files Coverage Δ
contracts/deployments/ReservesSetupHelper.sol 100.00% <ø> (ø)
contracts/flashloan/base/FlashLoanReceiverBase.sol 100.00% <ø> (ø)
...cts/flashloan/base/FlashLoanSimpleReceiverBase.sol 100.00% <ø> (ø)
contracts/misc/AaveOracle.sol 100.00% <ø> (ø)
contracts/misc/AaveProtocolDataProvider.sol 96.00% <ø> (ø)
contracts/misc/L2Encoder.sol 100.00% <ø> (ø)
contracts/misc/ZeroReserveInterestRateStrategy.sol 100.00% <ø> (ø)
contracts/protocol/configuration/ACLManager.sol 100.00% <ø> (ø)
...s/protocol/configuration/PoolAddressesProvider.sol 100.00% <ø> (ø)
...ol/configuration/PoolAddressesProviderRegistry.sol 100.00% <ø> (ø)
... and 29 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miguelmtzinf miguelmtzinf merged commit 6d6fa53 into master Oct 17, 2023
7 checks passed
@miguelmtzinf miguelmtzinf deleted the fix/919-solc-version branch October 17, 2023 08:12
Copy link

@Mackinassdre Mackinassdre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link

@halkk990 halkk990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MateuszAndrzejewski.2003@codecov-commenter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed solidity version in contracts impedes proper integration
6 participants