Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ValidationLogic.sol #940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ValidationLogic.sol #940

wants to merge 1 commit into from

Commits on Mar 10, 2024

  1. Update ValidationLogic.sol 

    The added natspec comment will help eliminate any misunderstandings/confusions around the implementation choice for the specific `require()` check in question.

Additionally, the current error message is somewhat misleading, as it clearly states below `<` HF liquidation threshold constant, while the implemented logic says `<=`.
So probably a good idea to change the error message to better reflect the actual implemented logic.
    @dappconsulting
    dappconsulting authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    9297085 View commit details
    Browse the repository at this point in the history