Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/discord link [skip cypress] #1776

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Chore/discord link [skip cypress] #1776

merged 4 commits into from
Sep 6, 2023

Conversation

foodaka
Copy link
Collaborator

@foodaka foodaka commented Sep 6, 2023

General Changes

  • Fixes XYZ bug
  • Adds XYZ feature

Developer Notes

Add any notes here that may be helpful for reviewers.


Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • Code changes have been quality checked in the ephemeral URL
  • QA verification has been completed
  • There are two or more approvals from the core team
  • Squash and merge has been checked

@height
Copy link

height bot commented Sep 6, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

sirsoth
sirsoth previously approved these changes Sep 6, 2023
@foodaka foodaka changed the title Chore/discord link Chore/discord link [skip cypress] Sep 6, 2023
@@ -41,8 +41,9 @@ export const TxErrorView = ({ txError }: { txError: TxErrorType }) => {

<Typography>
<Trans>
You can report incident to our <Link href="https://discord.gg/7kHKnkDEUf">Discord</Link>{' '}
or <Link href="https://github.com/aave/interface">Github</Link>.
You can report incident to our{' '}
Copy link
Contributor

@miguelmtzinf miguelmtzinf Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can report incident to our{' '}
You can report incident to our

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its auto formatted from prettier config

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 573.49 KB (-5 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

MareskoY
MareskoY previously approved these changes Sep 6, 2023
@foodaka foodaka dismissed stale reviews from MareskoY and sirsoth via 4da67d2 September 6, 2023 10:14
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 573.49 KB (-3 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@foodaka foodaka merged commit 058bd88 into main Sep 6, 2023
@foodaka foodaka deleted the chore/discord-link branch September 6, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants