Added support for select menus v2 #1540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsian03
requested changes
Sep 1, 2024
index.d.ts
Outdated
Comment on lines
1597
to
1608
| interface BaseSelectMenu extends SelectMenuBase { | ||
| type: Exclude<SelectMenuTypes, Constants["ComponentTypes"][keyof Pick<Constants["ComponentTypes"], "STRING_SELECT" | "CHANNEL_SELECT">]>; | ||
| } | ||
| interface SelectMenuBase { | ||
| custom_id: string; | ||
| disabled?: boolean; | ||
| default_values?: SelectDefaultValues[]; | ||
| max_values?: number; | ||
| min_values?: number; | ||
| options: SelectMenuOptions[]; | ||
| placeholder?: string; | ||
| type: Constants["ComponentTypes"]["SELECT_MENU"]; | ||
| type: SelectMenuTypes; | ||
| } |
There was a problem hiding this comment.
I'm confused as to the reason you are handling the parent select menu interface this way.
Also please remember to sort interfaces in alphabetical order
|
Also example file should be updated |
|
I'd appreciate an explanation rather than silently changing typings. Can you message me on the discord serve? discord.gg/eris |
…d' and 'non-resolved', removed the individual definitions for each of the select menu types and added a unified "ResolvedSelectMenus" interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select menus (v2) are here!
Added support for the second version of select menus discord/discord-api-docs#5543, as well as default_values for auto-populated select menus discord/discord-api-docs#6442