feat!: use pipx to isolate poetry

[NargiT]

Following poetry recommendation, it better to use pipx instead of pip to avoid mixing application dependencies with poetry's
https://python-poetry.org/docs/#ci-recommendations

BREAKING CHANGE: Switch using an isolated pipx virtualenv

[lucsorel]

I would also prefer poetry being installed with pipx for isolation sake. After using curl, it is the 2nd recommended way to install poetry (see https://python-poetry.org/docs/#installing-with-pipx).

Installing poetry using pip can cause dependency clashes with the project's dependencies if the project dependencies are not installed in a virtual environment.

[abatilo]

Thank you for the contribution @NargiT. I'm sorry that this got lost in my inbox. I like the spirit of the change but the changes break CI. Could you take a look?

[NargiT]

I will have a look, but expect some lags @abatilo 🌴

[lucsorel]

Looks good to me (this time, I checked the checkboxes of the files to review)

[lucsorel]

hi @abatilo

I reviewed the changes to this pull request but I don't understand why the process is still blocked 🤔 it looks like the CI must run but I don't understand how to trigger it.

[lucsorel]

@NargiT

After a quick look, it seems that the CI does not work because all tested versions of Poetry do not support the -U option that you use to install Poetry.

Either the obsolete versions of poetry should stop being supported (what is your advice, @abatilo?) or the github action must be tweaked to account for different major versions of poetry 🤷

[abatilo]

@lucsorel Your approval doesn't do anything because you don't have write permissions to this repository.

I believe if @NargiT pushes a new commit to the branch then that should trigger the workflows again.

[NargiT]

hello, I will check the -U option issue

[NargiT]

The "-U" is for pip, not poetry @lucsorel.

Could you tell me which combinaison of python, pip, poetry does not work ? Or simply the github action output ?

[lucsorel]

The "-U" is for pip, not poetry

Could you tell me which combinaison of python, pip, poetry does not work ? Or simply the github action output ?

You're totally right! Forgive me, it is pipx that sometimes complains about the -U options: see https://github.com/abatilo/actions-poetry/actions/runs/5524771665 and then click on the sub-jobs that failed, like this one https://github.com/abatilo/actions-poetry/actions/runs/5524771665/job/14960079176.

The jobs always fail for the "latest" version of poetry (as defined in this line of the github actions), which is surprising because -U is a pipx option, not a poetry one 🤔

[NargiT]

This should be good now

[abatilo]

@NargiT None of the required CI workflows have been triggered.

[NargiT]

@NargiT None of the required CI workflows have been triggered.

The maintainer should approve it in order to trigger the github action, I cannot do anything about it 😞

[lucsorel]

thank you @abatilo for approving the PR, thank you @NargiT for proposing it 😃

[abatilo]

Sorry to all that it took so long to get this finally merged in.