fix(tekton): Set a default PipelineRun timeout of 10 days

Starting in Tekton Pipelines v0.4.0, the default timeout for `TaskRun`s of 10 minutes when no timeout is specified is actually enforced. The only way to specify a timeout for a `TaskRun` is by setting a timeout on the `PipelineRun`, so until tektoncd/pipeline#978 and/or tektoncd/pipeline#979 are addressed, we should just set a ridiculously high timeout on all `PipelineRun`s. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer · Jun 12, 2019 · d6d194e · d6d194e
1 parent f4eaaee
commit d6d194e
Show file tree

Hide file tree

Showing 26 changed files with 47 additions and 18 deletions.
diff --git a/pkg/jx/cmd/step/create/step_create_task_test.go b/pkg/jx/cmd/step/create/step_create_task_test.go
@@ -380,6 +380,8 @@ func TestGenerateTektonCRDs(t *testing.T) {
 				}
 
 				if d := cmp.Diff(tekton_helpers_test.AssertLoadPipelineRun(t, caseDir), crds.PipelineRun()); d != "" {
+					pry, _ := yaml.Marshal(crds.PipelineRun())
+					t.Logf("PR: %s", pry)
 					t.Errorf("Generated PipelineRun did not match expected: %s", d)
 				}
 				if d := cmp.Diff(tekton_helpers_test.AssertLoadPipelineStructure(t, caseDir), crds.Structure()); d != "" {

diff --git a/...md/step/create/test_data/step_create_task/add-env-to-default-in-buildpack/pipelinerun.yml b/...md/step/create/test_data/step_create_task/add-env-to-default-in-buildpack/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-golang-qs-test-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/...est_data/step_create_task/append-and-prepend-stage-steps-in-jenkins-x-yml/pipelinerun.yml b/...est_data/step_create_task/append-and-prepend-stage-steps-in-jenkins-x-yml/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-js-test-repo-really-long
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/...cmd/step/create/test_data/step_create_task/append-and-prepend-stage-steps/pipelinerun.yml b/...cmd/step/create/test_data/step_create_task/append-and-prepend-stage-steps/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-jx-demo-qs-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
 status: {}
diff --git a/...jx/cmd/step/create/test_data/step_create_task/command-as-multiline-script/pipelinerun.yml b/...jx/cmd/step/create/test_data/step_create_task/command-as-multiline-script/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-js-test-repo-really-long
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/...step/create/test_data/step_create_task/containeroptions-on-pipelineconfig/pipelinerun.yml b/...step/create/test_data/step_create_task/containeroptions-on-pipelineconfig/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-jx-demo-qs-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
 status: {}
diff --git a/.../step/create/test_data/step_create_task/correct-pipeline-stage-is-removed/pipelinerun.yml b/.../step/create/test_data/step_create_task/correct-pipeline-stage-is-removed/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-js-test-repo-really-long
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/pkg/jx/cmd/step/create/test_data/step_create_task/default-in-buildpack/pipelinerun.yml b/pkg/jx/cmd/step/create/test_data/step_create_task/default-in-buildpack/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-golang-qs-test-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/pkg/jx/cmd/step/create/test_data/step_create_task/default-in-jenkins-x-yml/pipelinerun.yml b/pkg/jx/cmd/step/create/test_data/step_create_task/default-in-jenkins-x-yml/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-js-test-repo-really-long
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/pkg/jx/cmd/step/create/test_data/step_create_task/from_yaml/pipelinerun.yml b/pkg/jx/cmd/step/create/test_data/step_create_task/from_yaml/pipelinerun.yml
@@ -20,6 +20,8 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-js-test-repo-really-long
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/pkg/jx/cmd/step/create/test_data/step_create_task/js_build_pack/pipelinerun.yml b/pkg/jx/cmd/step/create/test_data/step_create_task/js_build_pack/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-js-test-repo-build-pack
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-    status: {}
+    status: {}
diff --git a/pkg/jx/cmd/step/create/test_data/step_create_task/kaniko_entrypoint/pipelinerun.yml b/pkg/jx/cmd/step/create/test_data/step_create_task/kaniko_entrypoint/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: jenkins-x-jx-fix-kaniko-special
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/pkg/jx/cmd/step/create/test_data/step_create_task/loop-in-buildpack-syntax/pipelinerun.yml b/pkg/jx/cmd/step/create/test_data/step_create_task/loop-in-buildpack-syntax/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-jx-demo-qs-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/pkg/jx/cmd/step/create/test_data/step_create_task/maven_build_pack/pipelinerun.yml b/pkg/jx/cmd/step/create/test_data/step_create_task/maven_build_pack/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-jx-demo-qs-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
 status: {}
diff --git a/...reate/test_data/step_create_task/override-agent-container-with-build-pack/pipelinerun.yml b/...reate/test_data/step_create_task/override-agent-container-with-build-pack/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-js-test-repo-override-de
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/.../cmd/step/create/test_data/step_create_task/override-default-in-buildpack/pipelinerun.yml b/.../cmd/step/create/test_data/step_create_task/override-default-in-buildpack/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-golang-qs-test-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/.../step/create/test_data/step_create_task/override-default-in-jenkins-x-yml/pipelinerun.yml b/.../step/create/test_data/step_create_task/override-default-in-jenkins-x-yml/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-js-test-repo-really-long
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/pkg/jx/cmd/step/create/test_data/step_create_task/override-steps/pipelinerun.yml b/pkg/jx/cmd/step/create/test_data/step_create_task/override-steps/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-jx-demo-qs-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/pkg/jx/cmd/step/create/test_data/step_create_task/override_block_step/pipelinerun.yml b/pkg/jx/cmd/step/create/test_data/step_create_task/override_block_step/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-golang-qs-test-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/.../cmd/step/create/test_data/step_create_task/per_step_container_build_pack/pipelinerun.yml b/.../cmd/step/create/test_data/step_create_task/per_step_container_build_pack/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-golang-qs-test-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
 status: {}
diff --git a/...md/step/create/test_data/step_create_task/remove-stage-from-jenkins-x-yml/pipelinerun.yml b/...md/step/create/test_data/step_create_task/remove-stage-from-jenkins-x-yml/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-js-test-repo-really-long
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/pkg/jx/cmd/step/create/test_data/step_create_task/remove-stage/pipelinerun.yml b/pkg/jx/cmd/step/create/test_data/step_create_task/remove-stage/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-jx-demo-qs-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
 status: {}
diff --git a/...ep/create/test_data/step_create_task/replace-stage-steps-in-jenkins-x-yml/pipelinerun.yml b/...ep/create/test_data/step_create_task/replace-stage-steps-in-jenkins-x-yml/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-js-test-repo-really-long
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/pkg/jx/cmd/step/create/test_data/step_create_task/replace-stage-steps/pipelinerun.yml b/pkg/jx/cmd/step/create/test_data/step_create_task/replace-stage-steps/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-jx-demo-qs-master
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
 status: {}
diff --git a/.../test_data/step_create_task/set-agent-container-with-agentless-build-pack/pipelinerun.yml b/.../test_data/step_create_task/set-agent-container-with-agentless-build-pack/pipelinerun.yml
@@ -20,6 +20,7 @@ spec:
         apiVersion: tekton.dev/v1alpha1
         name: abayer-js-test-repo-no-default
   serviceAccount: tekton-bot
+  timeout: 240h0m0s
   trigger:
     type: manual
-status: {}
+status: {}
diff --git a/pkg/tekton/pipelines.go b/pkg/tekton/pipelines.go
@@ -221,6 +221,8 @@ func CreatePipelineRun(resources []*pipelineapi.PipelineResource,
 			},
 			Resources: resourceBindings,
 			Params:    pipelineParams,
+			// TODO: This should be configurable, and we shouldn't have to set a timeout in the first place. See https://github.com/tektoncd/pipeline/issues/978
+			Timeout:   &metav1.Duration{ Duration: 240 * time.Hour},
 		},
 	}