Fix crash on start of Example app #107
Conversation
abbeycode
changed the title
There was a problem hiding this comment.
Thanks for pointing this out! I have a CI check that makes sure it always builds, but I don't run it often. I need to see if I can make a quick UI test that CI can run just to make sure it doesn't crash on startup.
I renamed this ticket and suggested an update to the CHANGELOG line (thanks for including that!) to reflect that it actually was compiling, it was just crashing on startup. Also would like to roll back the scheme upgrade check lines to keep the PR focused on what actually needed to change.
I also made some changes in the base branch to update the README and code to explain what's going on with Large Archive a little better. You should be able to click "Extract Large File" now and try it out.
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| * Fixed a header name conflict with Realm (Issue #90) | |||
| * Incorrect passwords in RAR5 archives now produce a specific and helpful error message (PR #101 - Thanks to [@gpotari](https://github.com/gpotari) for the idea and implementation!) | |||
| * Updated to v6.1.7 of UnRAR library (PR #103 - Thanks to [@gpotari](https://github.com/gpotari) ) | |||
| * Fixed compile error for Example project. Added missing CFBundleShortVersionString key to Info.plist | |||
There was a problem hiding this comment.
Please update the CHANGELOG to reflect the actual nature of the problem being fixed (a crash, not a compilation error).
| * Fixed compile error for Example project. Added missing CFBundleShortVersionString key to Info.plist | |
| * Fix crash on start of Example app (PR #107 - Thanks to [@gpotari](https://github.com/gpotari)) |
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <Scheme | |||
| LastUpgradeVersion = "1200" | |||
| LastUpgradeVersion = "1400" | |||
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <Scheme | |||
| LastUpgradeVersion = "1200" | |||
| LastUpgradeVersion = "1400" | |||
|
Forgot to mention that I was building with latest Xcode beta 4. And it actually didn't compile, gave me the mentioned error. |
|
Ok, that makes more sense. Feel free to and everything to “doesn’t compile with Xcode 14” |
|
Modified |
Fixes Building Example project.
Added missing short version string key to info.plist.
Also wanted to ask It is referencing a large-archive.rar that is not present in the repo. I can see the reason why, just wanted to ask just in case...