fix: Removed leaky abstraction #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Few things i wasn't sure about:
|
sethvargo
reviewed
Feb 9, 2022
capri-xiyue
reviewed
Feb 9, 2022
sethvargo
approved these changes
Feb 9, 2022
capri-xiyue
approved these changes
Feb 9, 2022
yolocs
requested changes
Feb 9, 2022
crwilcox
approved these changes
Feb 9, 2022
| @@ -102,20 +101,20 @@ func FromConfigFile(path string) audit.Option { | |||
| // s := grpc.NewServer(opt) | |||
| // ``` | |||
| // TODO(#109): add streaming interceptor. | |||
There was a problem hiding this comment.
is this still relevant to this func?
yolocs
approved these changes
Feb 9, 2022
yolocs
pushed a commit
that referenced
this pull request
Jun 13, 2023
* fix: Removed leaky abstraction * added error checking * add context to errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #76
Disclaimer: my golang knowledge is only slightly more than my cat's 🐱. Doing my best to be idomatic, but please let me know if you see things that seem odd or non-standard in golang.