Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use expire_at instead of expire_duration #19

Closed

Conversation

joeyparis
Copy link

@joeyparis joeyparis commented Nov 23, 2022

Add the option to pass an expire_at value to the LoginToken.encode method that overrides the global passwordless_login_within config value on a per-link basis. This does not yet implement the expire_at option for sending emails with the magic link, just the encode method for manual encoding.

Addresses #18

@abevoelker
Copy link
Owner

Thank you very much for your contribution! The option to provide an :expires_at key for token encoding1 has been implemented for the 1.0 release, and I've credited you in the CHANGELOG. 🎉 🙇‍♂️

Footnotes

  1. This logic now lives in the SignedGlobalIDTokenizer::encode and MessageEncryptorTokenizer::encode methods, now that the tokenization process is configurable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants